fix: replication policy cron setting - the 1st field must be 0; the M…

…inutes field cannot be *

Signed-off-by: Shengwen Yu <[email protected]>

src/controller/replication/model/model.go

@@ -108,6 +108,13 @@ func (p *Policy) Validate() error {
 				return errors.New(nil).WithCode(errors.BadRequestCode).
 					WithMessage("invalid cron string for scheduled trigger: %s", p.Trigger.Settings.Cron)
 			}
+			cronParts := strings.Split(p.Trigger.Settings.Cron, " ")
+			if cronParts[0] != "0" {
+				return errors.New(nil).WithCode(errors.BadRequestCode).WithMessage("the 1st field (indicating Seconds of time) of the cron setting must be 0")
+			}
+			if cronParts[1] == "*" {
+				return errors.New(nil).WithCode(errors.BadRequestCode).WithMessage("* is not allowed for the Minutes field of the cron setting of replication policy")
+			}
 		default:
 			return errors.New(nil).WithCode(errors.BadRequestCode).
 				WithMessage("invalid trigger type")

src/controller/replication/model/model_test.go

@@ -199,7 +199,7 @@ func TestValidate(t *testing.T) {
 	err = policy.Validate()
 	assert.True(errors.IsErr(err, errors.BadRequestCode))
 
-	// pass
+	// invalid cron: the 1st field (indicating Seconds of time) of the cron setting must be 0
 	policy = &Policy{
 		Name: "policy01",
 		SrcRegistry: &model.Registry{
@@ -226,5 +226,63 @@ func TestValidate(t *testing.T) {
 		},
 	}
 	err = policy.Validate()
+	assert.True(errors.IsErr(err, errors.BadRequestCode))
+
+	// invalid cron: * is not allowed for the Minutes field of the cron setting of replication policy
+	policy = &Policy{
+		Name: "policy01",
+		SrcRegistry: &model.Registry{
+			ID: 0,
+		},
+		DestRegistry: &model.Registry{
+			ID: 1,
+		},
+		Filters: []*model.Filter{
+			{
+				Type:  model.FilterTypeResource,
+				Value: "image",
+			},
+			{
+				Type:  model.FilterTypeName,
+				Value: "library/**",
+			},
+		},
+		Trigger: &model.Trigger{
+			Type: model.TriggerTypeScheduled,
+			Settings: &model.TriggerSettings{
+				Cron: "0 * * * * *",
+			},
+		},
+	}
+	err = policy.Validate()
+	assert.True(errors.IsErr(err, errors.BadRequestCode))
+
+	// pass
+	policy = &Policy{
+		Name: "policy01",
+		SrcRegistry: &model.Registry{
+			ID: 0,
+		},
+		DestRegistry: &model.Registry{
+			ID: 1,
+		},
+		Filters: []*model.Filter{
+			{
+				Type:  model.FilterTypeResource,
+				Value: "image",
+			},
+			{
+				Type:  model.FilterTypeName,
+				Value: "library/**",
+			},
+		},
+		Trigger: &model.Trigger{
+			Type: model.TriggerTypeScheduled,
+			Settings: &model.TriggerSettings{
+				Cron: "0 0 * * * *",
+			},
+		},
+	}
+	err = policy.Validate()
 	assert.Nil(err)
 }

src/controller/replication/policy_test.go

@@ -76,7 +76,7 @@ func (r *replicationTestSuite) TestCreatePolicy() {
 		Trigger: &model.Trigger{
 			Type: model.TriggerTypeScheduled,
 			Settings: &model.TriggerSettings{
-				Cron: "0 * * * * *",
+				Cron: "0 0 * * * *",
 			},
 		},
 		Enabled: true,
@@ -104,7 +104,7 @@ func (r *replicationTestSuite) TestUpdatePolicy() {
 		Trigger: &model.Trigger{
 			Type: model.TriggerTypeScheduled,
 			Settings: &model.TriggerSettings{
-				Cron: "0 * * * * *",
+				Cron: "0 0 * * * *",
 			},
 		},
 		Enabled: true,