Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using t.Cleanup in testing helpers #855

Open
ccoVeille opened this issue Jul 19, 2024 · 0 comments
Open

Consider using t.Cleanup in testing helpers #855

ccoVeille opened this issue Jul 19, 2024 · 0 comments
Labels
tests Related to linters, tests, coverage

Comments

@ccoVeille
Copy link
Contributor

I'm seeing a lot of defer like after calling a test helper

Why not, adding a t.Cleanup to getMockMQTT and gomock.NewController

And remove all this defer calls

Originally posted by @ccoVeille in #837 (comment)
@ccoVeille ccoVeille mentioned this issue Jul 20, 2024
Closed
@srijan-27 srijan-27 added the tests Related to linters, tests, coverage label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Related to linters, tests, coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoVeille @srijan-27