Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: document golang merge+testing procedure so others can run, pull-request? #6

Open
johnnyutahh opened this issue Aug 8, 2022 · 2 comments

Comments

@johnnyutahh
Copy link

If we can document the golang merge+test procedure I or others might try to execute said procedure and then submit a pull request whenever one wants a better golang merge.

Thoughts?

@johnnyutahh johnnyutahh changed the title proposal: affected/package: all: document golang merge+testing procedure? proposal: document golang merge+testing procedure so others can run, pull-request? Aug 8, 2022
@johnnyutahh
Copy link
Author

Checking in. Thoughts?

@diyism
Copy link

diyism commented Sep 28, 2022

Google guys have refused many times of pull requests about allman/horstmann style:
golang#39421
So we have to fork golang by ourselves.
I only modified 2 files:
https://forum.golangbridge.org/t/need-help-modify-two-scanner-go-files-to-support-allman-style-braces/24265/4

ref: https://stackoverflow.com/a/15644127/264181

git remote add golang git://github.com/golang/go.git
git fetch golang
git checkout -b master golang/release-branch.go1.20
git push -u origin master:main
#modify/add 7 files about gofork
git add .
git commit -a 'add 7 files about gofork'
git push

the 7 files:
046e70d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants