Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch ice invalid url error #145

Open
tlloancy opened this issue Apr 21, 2024 · 4 comments
Open

catch ice invalid url error #145

tlloancy opened this issue Apr 21, 2024 · 4 comments

Comments

@tlloancy
Copy link

tlloancy commented Apr 21, 2024

Godot version

4.2.2

Plugin version

0.2

System information

Windows 10

Issue description

icescrenne

HELLO, I would like to be able to catch the error displayed after what(), for user information purpose. Is that possible ?
[Edit] The Goal is to keep more track on steps and status of ice connections, for both dev and UI purpose

Steps to reproduce

my programm let the user choose his ice server. I'd like to inform him for any error like this one, where his url input is invalid

Minimal reproduction project

invoke ice server iceserverconfiguration

Tasks

Preview Give feedback
No tasks being tracked yet.
@Faless
Copy link
Collaborator

Faless commented Apr 22, 2024

@tlloancy can you please upload a minimum reproduction project? The screenshot you shared is not really an MRP, it's only part of the code, it can't be run, and people are not gonna copy your script from an image to test it.

@Faless
Copy link
Collaborator

Faless commented Apr 22, 2024

Plugin version

0.2

Also, please try updating to the latest version of the plugin: 1.0.6

@Faless
Copy link
Collaborator

Faless commented Apr 22, 2024

As you can see, we already catch the error in the latest version: https://github.com/godotengine/webrtc-native/blob/1.0.6-stable/src/WebRTCLibPeerConnection.cpp#L260-L272

@tlloancy
Copy link
Author

Hi, i know the error is correctly raised in webrtc as you can see in the first screenshot, but i would like to be able to catch that error at my app level in order to display the information as well as avoid crashing the app. i dont know how i am doing that. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants