[Windows/ARM64] Fix raycast/embree ARM64 build with LLVM/MinGW. #93364
Conversation
| @@ -102,7 +102,9 @@ | |||
| #include <stdint.h> | |||
| #include <stdlib.h> | |||
|
|
|||
| #if defined(_WIN32) | |||
| // -- GODOT start -- | |||
| #if defined(_WIN32) && !defined(__clang__) | |||
There was a problem hiding this comment.
Why doesn't it work on llvm-mingw specifically but works on mingw-w64-gcc?
There was a problem hiding this comment.
Most likely it's not clang but UCRT specific, but _mm_malloc is not found with this define.
There was a problem hiding this comment.
Also, this is ARM specific code, so MinGW-GCC might have it missing as well.
There was a problem hiding this comment.
Should we use !defined(__MINGW32__) then? It would make the comment lie though.
There was a problem hiding this comment.
Either way, worth PR'ing upstream to get more eyes on it and find out the proper fix there: https://github.com/DLTcollab/sse2neon
Downstream I'm fine with either option to get this to compile.
There was a problem hiding this comment.
I have checked headers for both MinGW/GCC and MinGW/LLVM, and it's only defined for x86 in both, so !defined(__MINGW32__) should be more correct.
There was a problem hiding this comment.
MSVC define it for all architectures, and it's just a macro for the same _aligned_malloc I have added, so it's the same.
There was a problem hiding this comment.
Then maybe it should just be _MSC_VER?
Is it defined for clang-cl?
There was a problem hiding this comment.
No idea, but __MINGW32__ definitely should not be defined.
There was a problem hiding this comment.
Upstream PR - DLTcollab/sse2neon#637
|
Thanks! |
No description provided.