Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when executing Image.save_jpg_to_buffer #91590

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix crash when executing Image.save_jpg_to_buffer #91590

merged 1 commit into from
Jul 5, 2024

Conversation

timothyqiu
Copy link
Member

Fixes #90715

It should duplicate the possibly decompressed image.

@timothyqiu timothyqiu added bug topic:core crash cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 5, 2024
@timothyqiu timothyqiu added this to the 4.3 milestone May 5, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner May 5, 2024 15:39
@timothyqiu timothyqiu added regression and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 5, 2024
@timothyqiu timothyqiu requested a review from Rubonnek May 8, 2024 10:28
@timothyqiu timothyqiu requested a review from akien-mga July 5, 2024 05:48
@akien-mga akien-mga merged commit 4f953cc into godotengine:master Jul 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the dupe branch July 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Rubonnek Rubonnek Awaiting requested review from Rubonnek

Assignees
No one assigned
Labels
bug crash regression topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Executing Image.save_jpg_to_buffer function crashes Godot
2 participants
@timothyqiu @akien-mga