Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the text editor consistent with the script editor #87510

Conversation

adamscott
Copy link
Member

I was editing the editor when I saw the inconsistent UI. Search and Edit swaps out in the text editor. This PR makes it consistent with the script editor.

master

Script editor

image

Text editor

image

This PR

Script editor

image

Text editor

image

@adamscott adamscott added this to the 4.3 milestone Jan 23, 2024
@adamscott adamscott requested a review from YuriSizov January 23, 2024 16:32
@Riteo
Copy link
Contributor

Riteo commented Jan 23, 2024

I think the pictures are the same?

@adamscott
Copy link
Member Author

I think the pictures are the same?

There's a difference between Script editor and Text editor on master. (search and edit are swapped out)

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'm kind of surprised that the top menu is created in two different places.

@adamscott
Copy link
Member Author

Makes sense. I'm kind of surprised that the top menu is created in two different places.

Me too. It could benefit from a refactor.

@kitbdev
Copy link
Contributor

kitbdev commented Jan 24, 2024

It could benefit from a refactor.

Related

@YuriSizov YuriSizov merged commit 10945f7 into godotengine:master Jan 24, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants