Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign light indices after sorting in OpenGL renderer #71772

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Assign light indices after sorting in OpenGL renderer #71772

merged 1 commit into from
Jan 21, 2023

Conversation

clayjohn
Copy link
Member

Fixes: #71710

This ensures that the light indices sent to the shader actually match where the light is saved. Previously we acquired the index in the light array before sorting the lights but then the indices became invalid once sorted.

@clayjohn
Assign light indices after sorting in OpenGL renderer
6d0af4f 
This ensures that the light indices sent to the shader actually match where the light is saved
@clayjohn clayjohn added this to the 4.0 milestone Jan 20, 2023
@clayjohn clayjohn requested a review from a team as a code owner January 20, 2023 23:45
@akien-mga akien-mga merged commit 4db3716 into godotengine:master Jan 21, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

OpenGL: multiple omni lights render incorrectly
2 participants
@clayjohn @akien-mga