-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] [HTML5] Add GDNative+Threads build. #61989
[3.x] [HTML5] Add GDNative+Threads build. #61989
Conversation
f32f1ca
to
1e94917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Given that it requires bleeding edge Emscripten and LLVM I guess it's a bit late for 3.5, we can likely merge this for 3.6?
I know it's very late, I was thinking maybe we could provide official builds in a point release (e.g. |
Yeah I mean the changes seem harmless enough so I don't mind merging it for 3.5 to enable in a point release later. But then we should maybe unexpose the "Threads and GDNative" export option to avoid confusion, as we won't be providing templates for it in 3.5.stable. You could keep it implemented but just not part of the property enum hint (and people who want to test with custom builds could set the value manually in their |
1e94917
to
65dc01b
Compare
Thanks! |
Requires an unreleased version of emscripten (or more correctly, a recent LLVM patch, see: emscripten-core/emscripten#17150 and https://reviews.llvm.org/D127333).
You can try it out by building LLVM from source, and overriding the LLVM version used by emscripten via the
EM_LLVM_ROOT
env variable (see here).Only template versions work, the editor fails to start (possibly related to emscripten-core/emscripten#15487):
Will open on a dedicated PR for master soon.