-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the maximum value of unbinds in the connection dialog to signal_argument_size #60187
Limit the maximum value of unbinds in the connection dialog to signal_argument_size #60187
Conversation
0830126
to
efeb4aa
Compare
efeb4aa
to
5028653
Compare
The unbinds spinbox could get disabled if max is 0, so users wouldn't wonder why it's non-functional. |
5028653
to
506a045
Compare
For parameters in the final Receiver Method parameter list, if divided by where they come from, currently, they can be divided into 3 categories, as I explained with different colors in the picture of #60143 (comment) (there, I added another one, the signal source, to increase flexibility of the connection dialog). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
As for the disabling the SpinBox I mentioned earlier, when the method has 0 arguments, the max value of unbind is 0. The SpinBox can still be interacted with, but clicking or typing anything has no effect. It might be confusing to some people, so maybe it would be better to disable it explicitly. But maybe I'm wrong. It's not that important.
Update editor/connections_dialog.cpp Co-authored-by: Tomek <[email protected]>
3f02ad3
to
fbba40f
Compare
Thanks! |
Previously, the range of
unbinds
was the default range ofSpinBox
([0, 100]
), now the maximum value is limited to thesize
of the parameter list of the Signal.And the value of
unbinds
is taken into account when generating the parameter list of the Receiver Method.I found
Script::has_script_signal
andScript::get_script_signal_list
, but there is noScript::get_script_signal
.