Rename Lod Threshold to Mesh Lod Threshold #56305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
Calinou
added
enhancement
topic:core
topic:3d
topic:rendering
and removed
topic:core
labels
JFonS
approved these changes
Jan 4, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more obvious that the setting only affects mesh LOD, not manual (H)LOD achieved using visibility ranges.
In the future, if we want to implement automatic LOD for point lights, particles or reflection probes, these will likely use their own LOD threshold values to allow for greater customization.
This doesn't break compatibility with
3.xprojects since Lod Threshold is new inmaster.