Fix C# get_all_delegates method for generic classes
#55563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
force-pushed
the
csharp-delegates-for-generic-class
branch
from
2bf3073 to
b45990d
Compare
neikeq
reviewed
Dec 4, 2021
| // If the class is generic we must use the generic type definition. | ||
| MonoClass *klass = mono_class; | ||
| MonoReflectionType *reftype = mono_type_get_object(mono_domain_get(), get_mono_type()); | ||
| if (GDMonoUtils::Marshal::type_is_generic(reftype)) { |
There was a problem hiding this comment.
I don't think you need this helper function. You should be able to do the same with mono_type_get_type(this->get_mono_type()) == MONO_TYPE_GENERICINST, but I haven't tested.
There was a problem hiding this comment.
It works, so I changed it.
If the class is generic, we must get its generic type definition and use it to retrieve the delegates.
raulsntos
force-pushed
the
csharp-delegates-for-generic-class
branch
from
b45990d to
d28be4d
Compare
neikeq
approved these changes
Dec 4, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the class is generic, we must get its generic type definition and use it to retrieve the delegates.
Closes #47830
I tested this PR using the 3.x version (#55564) because there seems to be an issue in
masterwith the Source Generators and generic types.