Fix RichTextLabel character horizontal offset calculation #52752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not relevant to
master
branch, because on master thex
offset inRichTextLabel
is properly treated as float (just like inLabel
code on 3.x branch).Fixes #22580
Horizontal offsets were assigned to the integer variables while the actual type of value returned by
get_char_size
is float (and is properly handled in plainLabel
). We were losing data in cases where character sizes were not integer values.