Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make radius & height in CapsuleShape3D independent #51522

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Make radius & height in CapsuleShape3D independent #51522

merged 1 commit into from
Aug 12, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Also changed CapsuleMesh to make settings consistent between render and physics.

This is the 3D counterpart of #41634, and fixes #25657.
CC @KoBeWi

@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Aug 11, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team August 11, 2021 17:45
@pouleyKetchoupp pouleyKetchoupp requested review from a team as code owners August 11, 2021 17:45
@akien-mga
Copy link
Member

Needs a rebase to fix CI.

@pouleyKetchoupp
Make radius & height in CapsuleShape3D independent
f9176a3 
Also changed CapsuleMesh to make settings consistent between render and
physics.
@pouleyKetchoupp pouleyKetchoupp force-pushed the capsule-3d-independent-height branch from a37fc85 to f9176a3 Compare August 11, 2021 21:55
@pouleyKetchoupp
Copy link
Contributor Author

@akien-mga Thanks! It's ready to go now.

@akien-mga akien-mga merged commit df598e8 into godotengine:master Aug 12, 2021
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp pouleyKetchoupp deleted the capsule-3d-independent-height branch August 12, 2021 15:09
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Aug 12, 2021
Merged
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Aug 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:editor topic:physics topic:3d usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Make the radius property in CapsuleShape not interfere with height.
2 participants
@pouleyKetchoupp @akien-mga