-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structs and fragment-to-light varyings for 3.4 #48075
Structs and fragment-to-light varyings for 3.4 #48075
Conversation
07d4e33
to
111d459
Compare
Sure thing. I also see a couple other small bugfixes in the commit history. I'll go through them tomorrow. Luckily they all seem small and easy to merge. |
… function" to 3.4
111d459
to
2d1f8f2
Compare
@Chaosus I have backported the remaining three changes from the set, and updated it to accommodate the recent reformatting update from last week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, and thank you, @lyuma. Unfortunaly I'm unable to check it up on my PC properly now (I'm in hospital) but I trust you and approve it.
Thanks! |
Backport of the following PRs by @Chaosus to 3.x, adding support for structs and the ability to declare varyings between fragment and light functions:
All changes support GLES2 and GLES3.
#35249 Implementation of struct for shaders
#36141 Added support for arrays as shader struct members
#44705 Fix using post-init shader array constructors
#44698 Allow passing varying from fragment to light shader function
#36251 Fix shader crash if duplicated struct members created
#46272 Prevents shader crash if passing invalid struct to the return statement
#46275 Prevents shader crash if two struct with the same name are declared