Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML5] Respect allow_hidpi option during setup #46801

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[HTML5] Respect allow_hidpi option during setup #46801

merged 1 commit into from
Mar 9, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Mar 8, 2021

The option was forced to true before, unlike on other platforms.

This fixes the HTML5 part of #28666 , which also seem to have slightly diverged from OP issue.

@Faless Faless added this to the 4.0 milestone Mar 8, 2021
@Faless Faless requested review from a team as code owners March 8, 2021 18:55
@Faless Faless mentioned this pull request Mar 8, 2021
Merged
@Faless Faless marked this pull request as draft March 8, 2021 19:40
@Faless
Copy link
Collaborator Author

Faless commented Mar 8, 2021

I converted this to draft. Because I realized that the linked issue about Viewport size is tied to the get_window_size returned value. Which I'm wondering if should always be the scaled down value even if HiDPI is on.

@Faless
[HTML5] Respect allow_hidpi option during setup
f34c798 
The option was forced to `true` before, unlike on other platforms.
@Faless Faless force-pushed the js/4.x_allow_hidpi branch from 7079107 to f34c798 Compare March 8, 2021 22:41
@Faless Faless marked this pull request as ready for review March 8, 2021 22:48
@Faless
Copy link
Collaborator Author

Faless commented Mar 8, 2021

Okay, this should be good to go now.

@akien-mga akien-mga merged commit ab585be into godotengine:master Mar 9, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:porting topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Faless @akien-mga