Expose bookmark, breakpoint, and mark safe functions in TextEdit #40629
Conversation
Calinou
added
cherrypick:3.x
|
Can this be 3.2 only? I need it for my code translation tool |
doc/classes/TextEdit.xml
Outdated
| <argument index="0" name="line" type="int"> | ||
| </argument> | ||
| <description> | ||
| Returns [code]true[/code] when the specified [code]line[/code] is bookmarked. |
There was a problem hiding this comment.
These should be indented one level more. Running doctool should fix it for you.
HaSa1002
requested review from
AndreaCatania,
hpvb,
neikeq,
reduz and
vnen
as code owners
I'm not fond of exposing those APIs which are made specifically for Godot's code editor and not for a general purpose text editor. They're so specific that it opens the way for users requesting adding other similar and highly use-case specific APIs... That being said this concern has been addressed in |
HaSa1002
force-pushed
the
expose-textedit-safe
branch
2 times, most recently
from
5ed24c6
to
e656af5
Compare
doc/classes/TextEdit.xml
Outdated
| @@ -261,6 +261,33 @@ | |||
| <description> | |||
| Returns whether the line at the specified index is hidden or not. | |||
| </description> | |||
| </method> | |||
| <method name="is_line_set_as_bookmark" qualifiers="const"> | |||
doc/classes/TextEdit.xml
Outdated
| @@ -356,6 +383,29 @@ | |||
| <description> | |||
| Sets the text for a specific line. | |||
| </description> | |||
| </method> | |||
| <method name="set_line_as_bookmark"> | |||
HaSa1002
force-pushed
the
expose-textedit-safe
branch
from
b895701
to
5cf3024
Compare
|
Sorry for the mess I created while changing the base. Should be same commit now. And fixed all the issues. Had to apply the patch by hand... |
HaSa1002
force-pushed
the
expose-textedit-safe
branch
from
d881348
to
4ff0df7
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:3.x
I am working on tool and need those functions exposed. I think they should be exposed, because they are public methods and you can even set the theme properties for them. There is a lot more to expose still...