Change when we can ERR_FAIL_COND and ERR_FAIL_CONV_V to static_assert #36385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuruk-mm
force-pushed
the
some_static_asserts
branch
2 times, most recently
from
274cc98 to
8cdeb6b
Compare
|
(just a random idea) Maybe this could become |
Maybe, but I would let this way if someone want to put an advice |
kuruk-mm
force-pushed
the
some_static_asserts
branch
from
8cdeb6b to
cec015f
Compare
kuruk-mm
force-pushed
the
some_static_asserts
branch
from
cec015f to
a5a6edf
Compare
akien-mga
reviewed
Mar 4, 2020
kuruk-mm
force-pushed
the
some_static_asserts
branch
from
a5a6edf to
c933eb7
Compare
neikeq
approved these changes
Mar 4, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36368 reduz said we can change some on those.
I found 4, I didn't find more.