Move the asset library API URL to the Editor Settings #31613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since changing the API URL is only needed for people working on the asset library, it doesn't need to be present in the asset library menus. This also allows setting the API URL to something else than the default or `localhost`. This also removes some duplicated default setting values. This closes godotengine#22046.
Calinou
force-pushed
the
assetlib-api-url-editor-settings
branch
from
5439773
to
cd2b4f8
Compare
|
The repository feature is meant to be used to add extra asset library repositories, so it shouldn't be removed IMO. |
|
@Calinou Any update? This needs to be rebased, and the above feedback needs to be addressed. |
|
@aaronfranke This needs to be remade from scratch at this point. I don't have time to do it right away, so it might be better to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changing the API URL is only needed for people working on the asset library, it doesn't need to be present in the asset library menus.
This also allows setting the API URL to something else than the default or
localhost.This also removes some duplicated default setting values.
This closes #22046 and partially addresses #5284.