Pin bottom panel does not work with some panels

[Giganzo]

Tested versions

Godot v4.4.dev5

System information

Fedora Linux 40 (KDE Plasma) on Wayland - X11 display driver, Single-window

Issue description

Pin bottom panel implemented in #98074 does not work for multiple panels.

Screencast_20241128_205052.webm

Steps to reproduce

Click pin and switch between nodes that have a bottom panel

Minimal reproduction project (MRP)

docks.zip

[AThousandShips]

As far as I can tell the intention was to keep permanent bottom panels open only, like "Output" and "Animation"

CC @YeldhamDev

[Giganzo]

As far as I can tell the intention was to keep permanent bottom panels open only, like "Output" and "Animation"

I cant see anything that mention this, the linked proposal that the PR closed says "Every time my AnimationTree" and this PR does not work for the AnimationTree.
Plus the Pin is visible for all of the above panels

[AThousandShips]

Animation tree isn't a permanent one either, does it work with Animation or Output? The linked proposal might have been incorrectly linked

[Giganzo]

Both proposals seems to be incorrectly linked?

Where does the PR says it only should work for permanent panels, and why is the pin visible for all?

[AThousandShips]

Let's see what the implementer of the feature says about the intentions, the discussion doesn't deal with the way to keep a bottom panel open when the relevant node is deselected, which is a bit more complex because the editor is deleted, so that to me indicates it was not meant to do that

[YeldhamDev]

What @AThousandShips says is correct, It was meant to keep available editors pinned, and Godot is coded to remove them once whatever is providing them isn't selected anymore. The feature could be extended so that those editors are forced to stay when toggled, but would require a deeper look and tackling that mechanism first.

EDIT: I took a look at it, and making plugins not be removed is the easy part. The actual problem is that the bottom panel is completely unaware about the plugins themselves, so a rewrite would be needed to either it or all the plugins that go in it to know when a bottom panel plugin is selected.