Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in Files does not work with empty Folder: res:// field #98116

Open
aniezurawski opened this issue Oct 12, 2024 · 3 comments
Open

Find in Files does not work with empty Folder: res:// field #98116

aniezurawski opened this issue Oct 12, 2024 · 3 comments

Comments

@aniezurawski
Copy link

aniezurawski commented Oct 12, 2024

Tested versions

Reproducible in:

  • Godot v4.3.stable

Not reproducible in:

  • Godot v4.2.1.stable

System information

Ubuntu 22.04.5 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 - AMD Ryzen 7 7800X3D 8-Core Processor (16 Threads)

Issue description

Find in Files (aka Ctrl+Shift+F) finds nothing unless you explicitly choose a folder to search in. So effectively you cannot search in whole res:// tree. Even if you have all your source code in single folder like src or scenes it's still very irritating because Folder is empty by default when Find in Files is open first time since relaunching Godot.

EDIT: Ok, I found out that it's because of existence of .gdignore file (even empty one) in main folder.

Steps to reproduce

  • Restart Godot
  • Select any word in any script
  • Ctrl+Shift+F
  • Click Find
  • No results

Minimal reproduction project (MRP)

N/A
It actually turned out to be project specific but I was not able to reproduce it in smaller project.

@AThousandShips
Copy link
Member

AThousandShips commented Oct 13, 2024

Ok, I found out that it's because of existence of .gdignore file (even empty one) in main folder.

This is expected, that's what that file does, this isn't supported IMO, there should probably be some error or similar when putting one in the main folder

Note that .gdignore should be empty, it is not like .gitignore, see here

It disabling search was implemented in:

@aniezurawski
Copy link
Author

Note that .gdignore should be empty, it is not like .gitignore, see [here]

Ok, somehow I got it wrong and have been working like this for quite some time with Godot 4.2.
I think it should work like .gitignore. But since it's definitely not a bug then I'm closing the issue. Thanks.

@AThousandShips
Copy link
Member

AThousandShips commented Oct 13, 2024

I think it should work like .gitignore.

Feel free to open a proposal for this (if one doesn't already exist)

However this should still be investigated as there's an issue with not handling these correctly in the root directory, we should probably throw a warning or change the behaviour of the find function for this case, or both

Unsure why it worked before that's another thing to look into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants