Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDExtension classes inheriting from Resource are not using icons in FileSystem #97387

Closed
Withaust opened this issue Sep 24, 2024 · 2 comments · Fixed by #97421
Closed

GDExtension classes inheriting from Resource are not using icons in FileSystem #97387

Withaust opened this issue Sep 24, 2024 · 2 comments · Fixed by #97421

Comments

@Withaust
Copy link
Contributor

Withaust commented Sep 24, 2024

Tested versions

4.3 dev 1

System information

Windows 10 Godot 4.3 dev 1 Vulkan

Issue description

I am aware there is #32706, but it does not seem to cover GDExtensions.

Currently, GDExtension classes inheriting from Resource are not using icons in FileSystem. It seems to work in every other place, but not in FileSystem for some reason.

image
image
image

Steps to reproduce

  1. Create a class in GDExtension that inherits Resource
  2. Assign an icon in .gdextension file to said class
  3. Observe how FileSystem is using default icon for this class, while the property viewer is displaying everything as expected

Minimal reproduction project (MRP)

You can see an example in the root of the project here
image
IconTest.zip

@akien-mga
Copy link
Member

Confirmed in 4.3.stable.

@SaNeOr
Copy link
Contributor

SaNeOr commented Sep 24, 2024

I've tested it, and found the same problem when using gdscript to inherit from resourcesubclasses, but there is another special feature of gdextension's icon, should need to get_class_icon() to get the icon_path.

@akien-mga akien-mga added this to the 4.4 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants