Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface/editor/editor_screen setting has no effect once window position is remembered #97051

Closed
KoBeWi opened this issue Sep 15, 2024 · 3 comments · Fixed by #97333
Closed

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 15, 2024

Tested versions

4.4 dev2

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

There is interface/editor/editor_screen editor setting, which defines where the editor should appear at startup. After #76085, the editor will use the last window position (including screen), making the setting effectively useless. It has effect only when a project is opened for the first time.

Maybe we should just remove this setting now.

Steps to reproduce

  1. Change interface/editor/editor_screen to Screen 1
  2. Restart the editor while it is on screen 2
  3. It starts on screen 2

Minimal reproduction project (MRP)

N/A

@akien-mga
Copy link
Member

We can either remove the setting, or change it to default to "Auto" that would be remembering the last position, and the other options should be treated as overrides.

@bits-by-brandon
Copy link
Contributor

I like the idea of an "Auto" setting. Perhaps we can merge in the separate interface/editor/remember_window_size_and_position setting into this "Auto" option?
Also some alternatives names for "Auto"

  • Persist
  • Remember

@bits-by-brandon
Copy link
Contributor

bits-by-brandon commented Sep 22, 2024

I have a really rough PR of what this might look like. #97333
I'm a total C++ beginner though, so it's not entirely functional yet 😅

@akien-mga akien-mga added this to the 4.4 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants