Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Scene shortcut does not work #95683

Closed
gatomesa opened this issue Aug 17, 2024 · 6 comments
Closed

Close Scene shortcut does not work #95683

gatomesa opened this issue Aug 17, 2024 · 6 comments

Comments

@gatomesa
Copy link

Tested versions

  • Reproducible in: 4.3.stable
  • Not reproducible in: 4.2.2.stable

System information

Godot v4.3.stable - macOS 14.5.0 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)

Issue description

The close scene shortcut, Cmd + Shift + W, does nothing in MacOS.

Steps to reproduce

Try using the close scene shortcut, Cmd + Shift + W.

Minimal reproduction project (MRP)

N/A

@KoBeWi
Copy link
Member

KoBeWi commented Aug 17, 2024

Seems like it's Ctrl+W on MacOS

godot/editor/editor_node.cpp

Lines 7152 to 7153 in 1bd740d

file_menu->add_shortcut(ED_SHORTCUT_AND_COMMAND("editor/close_scene", TTR("Close Scene"), KeyModifierMask::CMD_OR_CTRL + KeyModifierMask::SHIFT + Key::W), FILE_CLOSE);
ED_SHORTCUT_OVERRIDE("editor/close_scene", "macos", KeyModifierMask::CMD_OR_CTRL + Key::W);

@gatomesa
Copy link
Author

That's surprising, because in 4.2.2 it's Cmd + Shift + W. Also in the shortcuts reference: https://docs.godotengine.org/en/stable/tutorials/editor/default_key_mapping.html

@gatomesa
Copy link
Author

Testing it out a little more, it seems Cmd + W closes the scene, but only if you explicitly focus the scene tab. If the tab is not focused, it doesn't work.
Ctrl + W doesn't seem to do anything.

@VitikaSoni
Copy link
Contributor

For me, Cmd + W works without the tab being focused. Would like to know why its Ctrl+W only for macOS, and do we need to do anything about it.

@mhilbrunner
Copy link
Member

Would like to know why its Ctrl+W only for macOS

Seems it was an intentional change made here:
#88913

@mhilbrunner
Copy link
Member

Fixed by godotengine/godot-docs#10457, updating the docs. Thanks for reporting!

@akien-mga akien-mga added this to the 4.4 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants