Unexpected behaviour of set_process(false)

[Svarshick]

Tested versions

4.2.stable

System information

Godot v4.2.2.stable.mono - Ubuntu Core 22 - Wayland - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) - 12th Gen Intel(R) Core(TM) i5-12500H (16 Threads)

Issue description

I found out post about the same problem: #7894
As I understood the answer from reduz

We could add an extra check i guess

It was considered as bug. Let me know if not, please.
Issue was closed as completed.

Steps to reproduce

I created 2D Scene (Main) and added main.gd:

extends Node2D

var _active = false

func _process(delta):
	print("_process here!")

func _enter_tree():
	set_process(_active)
	print("Parent entered!")

Output:

Minimal reproduction project (MRP)

bug.zip

[huwpascoe]

_active should be false for the process to be disabled?

[Svarshick]

_active should be false for the process to be disabled?
Oh, I am sorry. Yes, it should be false. I may checked if it works with another parameters and forgot to change it

[huwpascoe]

Concluded testing, it only works with _ready.

func _init():
	set_process(false) # FAIL

func _enter_tree():
	set_process(false) # FAIL

func _ready():
	set_process(false) # OK

Don't know if this intended behavior or not.

[kleonc]

I found out post about the same problem: #7894 As I understood the answer from reduz

We could add an extra check i guess

It was considered as bug. Let me know if not, please. Issue was closed as completed.

#7894 describes a different problem than what is reported in here, and #7894 seems to be already solved/fixed indeed.

This issue is rather a duplicate of #31946. Basically if _process etc. is present/overridden within the script, then the relevant processing is enabled internally on NOTIFICATION_READY, which results in overwriting any previously set value (e.g. by set_process(_active) within _enter_tree like in the MRP):

godot/scene/main/node.cpp

Lines 193 to 215 in e343dbb

	case NOTIFICATION_READY: {
	if (GDVIRTUAL_IS_OVERRIDDEN(_input)) {
	set_process_input(true);
	}
	if (GDVIRTUAL_IS_OVERRIDDEN(_shortcut_input)) {
	set_process_shortcut_input(true);
	}
	if (GDVIRTUAL_IS_OVERRIDDEN(_unhandled_input)) {
	set_process_unhandled_input(true);
	}
	if (GDVIRTUAL_IS_OVERRIDDEN(_unhandled_key_input)) {
	set_process_unhandled_key_input(true);
	}
	if (GDVIRTUAL_IS_OVERRIDDEN(_process)) {
	set_process(true);
	}
	if (GDVIRTUAL_IS_OVERRIDDEN(_physics_process)) {
	set_physics_process(true);
	}

See also godotengine/godot-proposals#1008.

---

Tested versions

4.2.stable

System information

Godot v4.2.2.stable.mono - Ubuntu Core 22 - Wayland - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) - 12th Gen Intel(R) Core(TM) i5-12500H (16 Threads)

Note that in the 4.2.2 docs (thus in the current online stable docs as well) of Node.set_process etc. the potential overwrite on NOTIFICATION_READY is not mentioned anyhow, as:

• In Overhaul Node documentation #68560 notes like Any calls to this before [method _ready] will be ignored. were removed, it was cherry-picked into 4.2.2.
• New notes like If [method _process] is overridden, this will be automatically enabled before [method _ready] is called. were added in Post-merge fixes to Node & OS documentation #86903 (4.3-dev4+), it was not cherry-picked to 4.2 branch.

cc @Mickeon

[Mickeon]

Yeah, there's no reason not to cherrypick the next PR, if not because other minor PRs may have made it a bit annoying to.