Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontVariation variable font axes have two "default" values #93978

Closed
e-dog opened this issue Jul 5, 2024 · 3 comments
Closed

FontVariation variable font axes have two "default" values #93978

e-dog opened this issue Jul 5, 2024 · 3 comments

Comments

@e-dog
Copy link

e-dog commented Jul 5, 2024

Tested versions

  • Reproducible in 4.2.2.stable, 4.3.beta2

System information

Godot v4.3.beta2 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1660 (NVIDIA; 31.0.15.3623) - Intel(R) Core(TM) i5-2500 CPU @ 3.30GHz (4 Threads)

Issue description

FontVariation's variation coordinate "weight" displays default value of 100, while the actual value used for that axis is 400.

If set manually to 100 or 400, the displayed value resets to 100 displayed, and 400 actually used. If set to other values, like 101, 399, or 401, the displayed value persists and is used correctly for the font. This makes it impossible to set font weight to exactly 100.

The same is true for other axes, for example, "width" displays default value 62, but actually uses 100.

Steps to reproduce

  1. Create or select a FontVariation resource. Make sure "Base Font" is set to a variable font.
  2. In the Inspector, click to open "Variation" roll-out.
  3. Click on "OpenType - Variation Coordinates" right side to access variation axes / coordinates list.
  4. Observe default value of 100 for "Weight".
    • Optionally, use the font somewhere, and observe the actual used weight of 400 (regular).
  5. Change "Weight" value to 400.
  6. Click on "Variation Coordinates" two times to close and re-open the list of variation axes.
  7. Observe that "Weight" value changed to default 100 after re-opening the list, but Variation Coordinates are marked as changed.
    • Optionally, use the font somewhere, and observe the actual used weight of 400 (regular).
  8. Change "Weight" value to anything other than 100 or 400, for example: 101, 399, 401, 700, 900.
  9. Close and re-open the list, and observe that the changed value is NOT reset to the default 100.
    • Optionally, use the font somewhere, and observe that the actual used weight is consistent with the inspector's setting.

Minimal reproduction project (MRP)

FontVariationBug.zip

@bruvzg
Copy link
Member

bruvzg commented Jul 5, 2024

Should be fixed by #93957

@AThousandShips
Copy link
Member

Can someone confirm this is fixed?

@Calinou
Copy link
Member

Calinou commented Aug 7, 2024

Can someone confirm this is fixed?

I can confirm this is fixed as of 4.3.rc e343dbb (tested with the Inter Variable font from its official website).

@Calinou Calinou closed this as completed Aug 7, 2024
@Calinou Calinou added this to the 4.3 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants