Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crashes on undos when accidentally duplicate scene node while editing SpriteFrames. #93845

Closed
EAinsley opened this issue Jul 2, 2024 · 2 comments · Fixed by #93846
Closed

Comments

@EAinsley
Copy link
Contributor

EAinsley commented Jul 2, 2024

Tested versions

Reproducible in v4.2.2.stable.official [15073af], v4.3.beta2.official [b75f048], and v4.3.beta.custom_build [4ab8fb8].

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (NVIDIA; 31.0.15.3623) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

When editing SpriteFrames, move the mouse to the main panel and the focus changed to Scene Tree. Use shortcut to duplicate the nodes in the scene tree. After that, try to undo twice. The editor will crash.

crash_test.mp4

Steps to reproduce

  1. Create Node2D Scene.
  2. Add AnimatedSprite2D and create SpriteFrames.
  3. Open the SpriteFrames editor, and add a new animation.
  4. Move the mouse to the main viewport (no need to click) and use ctrl + d.
  5. Press ctrl + z twice.
  6. Wait a while, the editor will crash.

Minimal reproduction project (MRP)

N/A

@EAinsley
Copy link
Contributor Author

EAinsley commented Jul 2, 2024

On step 5, only press ctrl + z once and then open the SpriteFrames Editor again. It will show 'editor\editor_node.cpp:7751 - Condition "plugins_list.has(p_plugin)" is true.'

has_p_plugins.mp4

@EAinsley
Copy link
Contributor Author

EAinsley commented Jul 2, 2024

May also be related to #84093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants