Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker eyedropper tool selects Node instead of picking color in single window mode #93718

Closed
bogcow opened this issue Jun 28, 2024 · 4 comments · Fixed by #94931
Closed

Comments

@bogcow
Copy link

bogcow commented Jun 28, 2024

Tested versions

4.3.beta2

System information

Windows 10

Issue description

2024-06-28.16-18-21.mp4

In the video, I try to use the eyedropper tool of the ColorPicker, but whenever I select the red color (which is a ColorRect), instead of properly changing the color, the red ColorRect is selected instead. This behavior seems much more consistent when you are on single window mode, but it also occurs when you are not on single window mode as well.

Steps to reproduce

  • Download the sample project
  • Change editor settings to enable single window mode
  • Try to change the modulate property of the white ColorRect by using the color picker eyedropper onto the red area

Minimal reproduction project (MRP)

Test.zip

@matheusmdx
Copy link
Contributor

Bisecting points to #74962 as the culprit:

image


I also tried to reproduce the issue without --single-window but wasn't able to replicate.

@cjmaxik
Copy link

cjmaxik commented Jul 29, 2024

Still reproducible in 4.3-rc1

@akien-mga akien-mga changed the title Color Picker eyedropper tool selects Node instead of picking color Color Picker eyedropper tool selects Node instead of picking color in single window mode Jul 29, 2024
@akien-mga
Copy link
Member

CC @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented Jul 29, 2024

It's worse than that. When another node gets selected, the color change is not stored in undo history.

EDIT:
The issue is caused by inconsistency between single-window and multi-window modes. In single-window mode, clicking outside popup will pass the event further, instead of ignoring it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants