Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor animation performance #92724

Closed
WOLFxxxxxx opened this issue Jun 3, 2024 · 20 comments
Closed

Poor animation performance #92724

WOLFxxxxxx opened this issue Jun 3, 2024 · 20 comments

Comments

@WOLFxxxxxx
Copy link

Tested versions

4.3

System information

Windows 10

Issue description

The animation performance is very bad. The rest of the engines are 5 times better in performance
Please do well 🤕
1
324183392-8c49c03c-e34a-472a-963f-08cf6431a0e0

Steps to reproduce

Q

Minimal reproduction project (MRP)

anm.zip

@AThousandShips
Copy link
Member

AThousandShips commented Jun 3, 2024

You already reported exactly this before:

Why did you open a new report?

See #90943 (comment) for more details

@WOLFxxxxxx
Copy link
Author

I added a ZIP project

@AThousandShips
Copy link
Member

That should have been added to the original instead, but I don't think this changes anything, there was already an explanation there in the original

@WOLFxxxxxx
Copy link
Author

My game development depends on animation optimization

@AThousandShips
Copy link
Member

Yes, that's understood, but the cause of this issue was already explained in the original issue report, see the comment I linked, is that not relevant? If so then please explain how it is different from that

@WOLFxxxxxx
Copy link
Author

I'm sorry, I don't speak English very well.

@AThousandShips
Copy link
Member

AThousandShips commented Jun 3, 2024

That's okay, please use translation software or have someone help you, but it doesn't help if you ignore the things people tell you

Please use things like google translate and ask questions if there's something you don't understand (I used it on the original issue to my native language and I could understand it very well, and my language is a very small one so it should work for your language as well)

@WOLFxxxxxx
Copy link
Author

The old report was stopped without solving the problem

You open a new report

@AThousandShips
Copy link
Member

The old report was stopped without solving the problem

No, the explanation was given, please read this #90943 (comment)

You don't open a new report just because the answer wasn't what you wanted

@WOLFxxxxxx
Copy link
Author

Thank you for your help so I can repeat this plan again

@JekSun97
Copy link
Contributor

JekSun97 commented Jun 3, 2024

@WOLFxxxxxx There is no doubt that Godot's skeletal animation is not the most productive, but it is one of the most versatile. This also depends on your equipment, my FPS is stable
anmp

@JekSun97
Copy link
Contributor

JekSun97 commented Jun 3, 2024

I doubled the number of skeletons for a total of 200 skeletons and the fps remained stable
anmp2

@AThousandShips
Copy link
Member

AThousandShips commented Jun 3, 2024

200 skeletons might not necessarily be something I'd expect to run well generally, so it managing that is IMO pretty impressive, and not at all a sign of the engine being in desperate need of improvement. We can always do better but 200 skeletons is far above a minimum reasonable limit to me, assuming you don't have the most brutal newest hardware.

Edit: Testing this myself it struggles a bit with 200 skeletons but might just be other limitations right now my computer has been running a bit slow, but it runs perfectly fine with the original 100

So I'd say this is not a massively critical issue but rather areas where performance can be improved, and that in a lot of cases other methods for improving scaling of entities should be used if you need a lot of animated figures, things like using the servers directly or using multimesh etc., I'm not sure what the reasonable performance limits are for these cases when doing things with no optimizations or tricks to improve things used at all

@JekSun97
Copy link
Contributor

JekSun97 commented Jun 3, 2024

@AThousandShips I noticed an error in the console when duplicating a scene with a skeleton, should I open an error about this?
err

@AThousandShips
Copy link
Member

AThousandShips commented Jun 3, 2024

That's a reported case already I think, related to instanced scenes and not skeletons necessarily, search for it and see

@WOLFxxxxxx
Copy link
Author

Capture
2
The problem is with the CPU

@WOLFxxxxxx
Copy link
Author

There is a bottleneck

gpu 18%
cpu 31%

fps 15 - 30 ?????

@AThousandShips
Copy link
Member

Yes, that's what you were told in the original issue report, and you were told how to go forward with that

@WOLFxxxxxx
Copy link
Author

@Calinou
Copy link
Member

Calinou commented Jun 3, 2024

Closing in favor of #92693, which is more detailed and actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants