Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing light_specular is not available in the DirectionalLight3D inspector settings #92400

Closed
mishkarch opened this issue May 26, 2024 · 2 comments

Comments

@mishkarch
Copy link

mishkarch commented May 26, 2024

Tested versions

4.2.2 stable

System information

Windows (I think it's not matter)

Issue description

Hello. According to the documentation, Light3D has a light_specular property. DirectionalLight3D inherits from it, however, when added to the scene, in the inspector properties it is not possible to edit light_specular. (At the same time, the official tutorial on fake global illumination directly advises creating a DirectionalLight3D and setting to zero its specular.)
OmniLight3D and SpotLight3D are fine in this regard.

Steps to reproduce

Create a scene, add DirectionalLight3D.

Minimal reproduction project (MRP)

N/A

@Chaosus
Copy link
Member

Chaosus commented Jun 15, 2024

Looks like it's not implemented:

godot/scene/3d/light_3d.cpp

Lines 535 to 538 in 71699e0

if (p_property.name == "light_size" || p_property.name == "light_projector" || p_property.name == "light_specular") {
// Not implemented in DirectionalLight3D (`light_size` is replaced by `light_angular_distance`).
p_property.usage = PROPERTY_USAGE_NONE;
}

@Calinou
Copy link
Member

Calinou commented Jun 15, 2024

Thanks for the report! Consolidating in #80737.

@Calinou Calinou closed this as completed Jun 15, 2024
@Chaosus Chaosus closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants