Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global uniform does not exist error on project startup #92088

Closed
EspeuteClement opened this issue May 18, 2024 · 4 comments
Closed

Global uniform does not exist error on project startup #92088

EspeuteClement opened this issue May 18, 2024 · 4 comments

Comments

@EspeuteClement
Copy link
Contributor

Tested versions

v4.3.dev6.official [89850d5]

System information

Godot v4.3.dev6 - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; 31.0.15.3699) - AMD Ryzen 5 2600 Six-Core Processor (12 Threads)

Issue description

When opening a project that uses a global uniform of type sampler 2d, an error is shown in the godot console output Global uniform 'noise' does not exist. Create it in Project Settings. while the uniform actually exist in the project.

This was also reported in a new comment on a closed issue here : #57200 (comment)

Steps to reproduce

  1. Create a project using the Mobile render target, create a new global uniform named noise of type sampler 2d, set it to a noise texture
  2. Create the following shader
shader_type canvas_item;

global uniform sampler2D noise;

void fragment() {
	COLOR = texture(noise, UV);
}
  1. Assing the shader to a sprite2d node, save the scene, reload the editor
  2. Observe the error messages in the ouput console

Minimal reproduction project (MRP)

globaluniform.zip

@matheusmdx
Copy link
Contributor

I did the test and i can confirm the error happens, also this a regression caused by #60965 in v4.3.dev1

image

A thing i noticied while i did my test is another bug: When i create a resource directly in the project settings option, the resource is never saved inside the project file, using notepad++ i see the file changed but when i reload nothing changes and the resource is not stored. Now if i use a resource already saved in a separated file, the project file updates correctly. Revert #60965 doesn't solve this part.

unknown_2024.05.19-20.51_1.mp4

@akien-mga akien-mga added this to the 4.3 milestone May 20, 2024
@akien-mga akien-mga moved this from Unassessed to Bad in 4.x Release Blockers May 20, 2024
@akien-mga
Copy link
Member

CC @DarkMessiah @KoBeWi

@matheusmdx
Copy link
Contributor

I tested compiling from master daa81bb and this error was already solved by #91414

image

The resources not being saved in the global shaders problem persists, should a separated issue be opened for that?

@akien-mga
Copy link
Member

I tested compiling from master daa81bb and this error was already solved by #91414

Thanks, closing as fixed by #91414.

The resources not being saved in the global shaders problem persists, should a separated issue be opened for that?

Yes, that sounds relevant. Could you open one if you have a reproduction project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

No branches or pull requests

4 participants