Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 4.3dev6: When selecting multiple MeshInstance3D, menu Mesh is not available #91592

Closed
Nodragem opened this issue May 5, 2024 · 3 comments · Fixed by #91620
Closed

Comments

@Nodragem
Copy link
Contributor

Nodragem commented May 5, 2024

Tested versions

4.3dev6

System information

Godot v4.3.dev6 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 31.0.15.4626) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)

Issue description

In 4.2.2, we could select multiple MeshInstance3D and use the Mesh menu. This was incredibly useful for batch processing such as creating simple colliders for hundreds of mesh in a modular kit (i.e. for a Gridmap):
multi-editing-mesh-4 2

In 4.3dev6, the Mesh menu disapears when we select more than one Mesh; which prevents batch processing:
multi-editing-mesh-4 3dev6

I am really excited about #86627 by the way!

Steps to reproduce

See GIF above.

Minimal reproduction project (MRP)

You just need to create a couple of MeshInstance3D with a MeshBox as shape.

@matheusmdx
Copy link
Contributor

Bisecting leads to #89179 as the culprit

Revert this part of code in editor_node.cpp solves the problem
image

@akien-mga
Copy link
Member

CC @groud @KoBeWi

@akien-mga akien-mga added this to the 4.3 milestone May 6, 2024
@akien-mga akien-mga moved this from Unassessed to Bad in 4.x Release Blockers May 6, 2024
@KoBeWi
Copy link
Member

KoBeWi commented May 6, 2024

The Mesh menu did appear, but only one option is functional with multiple nodes 🙃 This regression can be considered a bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

5 participants