-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation errors with Windows/MSVC from VS 2019 after mbedTLS update #90526
Comments
That's really weird, the MSVC CI seems to pass, what version of visual studio / MSVC are you using? Can you try doing a clean build (i.e. after a |
Works fine for me on MSVC cl 19.34 |
19.29.30146 EDIT:
Same. |
I'm not getting any of this on MSVC VC 2022 (17.9.6, cl 19.39.33523), on Windows 11. Maybe it's picking up some old object files. Or it's an issue with the specific MSVC version. |
KoBeWi seems to be on VS 2019, so that's likely specific to VS 2019 and earlier. The upstream bug report mentions VS 2017 too. Mbed-TLS/mbedtls#7087 |
Tried building it with MSVC 2015, but it's not C++17 capable, so can't build Godot at all. I do not have 2019 installation to test. |
I can confirm this with VS 2019 latest (16.11.27). |
So, I think I found the cause, and as far as I understand it's a compiler bug (and indeed both the VS2019 C compiler and the VS2022 C++ resolves this correctly). The code problematic for VS2019 C++ compiler is in the form:
Which for some reason causes the first function declaration to be resolved as I've opened #90535 which disables the function declarations in that form when C++ and MSVC are detected. |
Tested versions
Regression from 40fa684 / #90482
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
When trying to compile on Windows, the compilation fails on crypto stuff:
Steps to reproduce
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: