Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Crashes when typing in the name of a particular custom node #90463

Closed
ThePhantomLemon opened this issue Apr 10, 2024 · 2 comments
Closed

Comments

@ThePhantomLemon
Copy link

Tested versions

  • Reproducible in: 4.3-dev5, 4.3-stable (only 2 tested)

System information

Godot v4.3.dev5 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2080 Ti (NVIDIA; 31.0.15.5186) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)

Issue description

If you have a custom node that contains an error, and inherits from another node, and your custom node's name contains the parent node's name, the editor will crash when you try to search the parent node in the "add node" menu. That's the best I can do. The steps to reproduce should clarify what I'm talking about. It's worth noting that the names don't seem to matter too much, but do seem to need to follow a [name] & [prefix][name] pattern.

Steps to reproduce

1: Make a new project
2: create these two files:

# S.gd
class_name S
extends Node
#AS.gd
class_name AS
extends S

var a: A

3: click the add node button and search "s"

Minimal reproduction project (MRP)

no-s.zip

@Maran23
Copy link
Contributor

Maran23 commented May 15, 2024

This might be fixed by #86447.
See also: #90483

@Calinou
Copy link
Member

Calinou commented May 16, 2024

I can confirm this was fixed by #86447. (I could reproduce the issue with the MRP before that PR was merged.)

@Calinou Calinou closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants