Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window.force_native forces edited scene's windows to be native in the editor #89669

Closed
mieldepoche opened this issue Mar 19, 2024 · 0 comments · Fixed by #89673
Closed

Window.force_native forces edited scene's windows to be native in the editor #89669

mieldepoche opened this issue Mar 19, 2024 · 0 comments · Fixed by #89673

Comments

@mieldepoche
Copy link
Contributor

mieldepoche commented Mar 19, 2024

Tested versions

System information

linux

Issue description

When enabling the force_native flag in a Window node, this window becomes native in the editor: a new os window appears...
force_native shouldn't take effect in the editor I think.

Additionally, the window correctly disappears when switching scenes but under some circumstances it can be leaked or the editor can crash:

Window duplication
  • In this clip, I repeatedly toggle the force_native flag and reload the scene.

  • setting the force_native flag to false and reloading the scene "disconnects" the window from the os window (the os window still hangs there):
    image

  • notice how moving the os window changes its properties in the inspector (at 0:06 in the clip).

simplescreenrecorder-2024-03-19_09.04.19.mp4
Crash
  • if the window node spawned an os window, and then had its force_native flag set to false, and then has its visibility toggled, the editor crashes (but changing position and size works fine).
simplescreenrecorder-2024-03-19_09.24.47.mp4

Steps to reproduce

  • add a Window node
  • enable its force_native flag and save and reload the scene
  • a new os window should spawn (which I believe is an issue)
  • additionally, if you now set the flag back to false and save and reload the scene, the window should still be here

Minimal reproduction project (MRP)

any

@mieldepoche mieldepoche changed the title Window.force_native forces windows to be native in the editor Window.force_native forces edited scene's windows to be native in the editor Mar 19, 2024
@bruvzg bruvzg self-assigned this Mar 19, 2024
@bruvzg bruvzg added this to the 4.3 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants