Running --doctool results in error message: ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true.

[Calinou]

• Related to Running --doctool results in error message: ERROR: unimplemented base type encountered in renderer scene cull #88096.

Tested versions

• Reproducible in: 4.3.dev f6aabd2 and later
• Not reproducible in: 4.2.1.stable, 4.3.dev3

System information

Godot v4.3.dev (f6aabd2) - Fedora Linux 39 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

Running --doctool always results in these 6 error messages:

ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)
ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)
ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)
ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)
ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)
ERROR: Condition "actions.default_repeat == ShaderLanguage::REPEAT_DEFAULT" is true. Returning: String()
   at: _get_sampler_name (./servers/rendering/shader_compiler.cpp:283)

Despite this, --doctool generates correct output.

I bisected the regression to f6aabd2. cc @jsjtxietian

We might want to look into detecting this on CI, perhaps with a CLI argument that makes Godot exit with a non-zero exit code (but continue running as normal) if any error is printed during its run. This would also help with #83042.

Steps to reproduce

Run a Godot editor binary with the --doctool command line argument.

Minimal reproduction project (MRP)

N/A

[clayjohn]

Looks like it is now running this block when it didn't run it before:

godot/servers/rendering/shader_compiler.cpp

Line 1259 in df78c06

if (correct_texture_uniform && !RS::get_singleton()->is_low_end()) {

That being said, there is no reason this should fail.

An easy workaround might be to assign the default_repeat value when creating the actions here:
https://github.com/godotengine/godot/blob/df78c0636d79c9545a283e0e2a926d623998cc27/servers/rendering/dummy/storage/material_storage.cpp#L39C18-L39C41

[clayjohn]

Actually, looks like this is a regression from #88021 originally. It sets the default to REPEAT_DEFAULT here:

godot/servers/rendering/shader_compiler.h

Lines 94 to 95 in df78c06

	ShaderLanguage::TextureFilter default_filter = ShaderLanguage::TextureFilter::FILTER_DEFAULT;
	ShaderLanguage::TextureRepeat default_repeat = ShaderLanguage::TextureRepeat::REPEAT_DEFAULT;

Since REPEAT_DEFAULT is never a valid setting, it needs to be changed when actions is initialized.

I would change the lines to:

ShaderLanguage::TextureFilter default_filter = ShaderLanguage::TextureFilter::FILTER_NEAREST; 
ShaderLanguage::TextureRepeat default_repeat = ShaderLanguage::TextureRepeat::REPEAT_DISABLE;