Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Skeletons not visible in Compatibility Mode #88937

Closed
chrisl8 opened this issue Feb 27, 2024 · 2 comments · Fixed by #88938
Closed

2D Skeletons not visible in Compatibility Mode #88937

chrisl8 opened this issue Feb 27, 2024 · 2 comments · Fixed by #88938

Comments

@chrisl8
Copy link
Contributor

chrisl8 commented Feb 27, 2024

Tested versions

in Compatibility Mode

v4.3.dev.custom_build [4a30fe5]

Reproducible on Windows when building at commit 4a30fe5 and any commit after that up to and including Master
Not reproducible when building at commit 35cfbdd

System information

Godot v4.3.dev (4a30fe5) - Windows 10.0.22621 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 Ti (NVIDIA; 31.0.15.5161) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)

Issue description

2D textures do not appear to show up at all after #86564 was merged.

Steps to reproduce

Download Godot's Skeleton2D Demo from https://github.com/godotengine/godot-demo-projects/tree/master/2d/skeleton

Open it and run it in Compatibility Mode and the character is not visible on the screen.

image

Minimal reproduction project (MRP)

Use the Godot demo project https://github.com/godotengine/godot-demo-projects/tree/master/2d/skeleton

@chrisl8 chrisl8 changed the title PR#86564 appears to break 2D Textures entirely PR#86564 appears to break 2D Textures entirely in Compatibility Mode Feb 27, 2024
@akien-mga akien-mga added this to the 4.3 milestone Feb 27, 2024
@akien-mga
Copy link
Member

CC @godotengine/rendering @Giwayume

@akien-mga akien-mga moved this from Unassessed to Release Blocker in 4.x Release Blockers Feb 27, 2024
@clayjohn clayjohn self-assigned this Feb 27, 2024
@clayjohn clayjohn changed the title PR#86564 appears to break 2D Textures entirely in Compatibility Mode 2D Skeletons not visible in Compatibility Mode Feb 27, 2024
@clayjohn
Copy link
Member

Thanks for the report! Identifying the problematic PR made it a very quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging a pull request may close this issue.

3 participants