Color picker commits live changes, but does not allow undo.

[MajorMcDoom]

Tested versions

Reproducible in 4.3.dev and 4.2.1 stable.

System information

Godot v4.3.dev (dd81433c8) - Windows 10.0.22621 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 1660 SUPER (NVIDIA; 31.0.15.5123) - Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz (16 Threads)

Issue description

The color picker commits color changes to the undo history, live, while you are previewing. This is odd on its own, but it is particularly cumbersome because it also does not allow you to undo until after you've closed the dialog. While the dialog is open, all undo/redo shortcuts are piped into the various input fields.

The expected behaviour is that the entire dialog session should only result in one operation if confirmed, but no operation at all if canceled. A less ideal solution would be to at least allow undoing the color changes from the picker dialog where you make the changes.

Steps to reproduce

• Open any color picker.
• Change the color.
• Wait a second or so.
• Change the color again.
• Try to undo, and note that it is impossible.

Minimal reproduction project (MRP)

N/A

[AThousandShips]

If any tooltips show in the color picker dialog, they steal focus away from all input fields. This is particularly problematic when clicking on the hex code field, typing, then getting immediately interrupted by the tooltip that pops up from the same field.

Tracked in:

• Color picker in editor doesn't allow entering code values #69065

If you change the color while in the dialog (using any means), wait for a second or so, then quit out of the dialog, the same color will be committed an additional time, requiring two undos to revert.

Tracked in:

• Undoing color change in Inspector requires two Crtl-Z's (sometimes) #83642

Please search for existing issues (including closed ones), and also please open one issue report for one bug, these are different bugs in practice (ignoring the duplicates) so needs to be tracked independently :)

[MajorMcDoom]

@AThousandShips Gotcha, will refine and open separate bugs where applicable.

[AThousandShips]

(To clarify, becasue I realized I wasn't clear and could come across wrong, meant to search for other issues when splitting this into two :) not criticism)

[MajorMcDoom]

(To clarify, becasue I realized I wasn't clear and could come across wrong, meant to search for other issues when splitting this into two :) not criticism)

Either way, it was feedback that made sense. Thanks!
For what it's worth, I do suspect all these issues have the same underlying cause.