Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error spam on mobile renderer (usage type error) #88606

Closed
BastiaanOlij opened this issue Feb 20, 2024 · 5 comments · Fixed by #88631
Closed

Error spam on mobile renderer (usage type error) #88606

BastiaanOlij opened this issue Feb 20, 2024 · 5 comments · Fixed by #88631

Comments

@BastiaanOlij
Copy link
Contributor

Tested versions

  • Reproducable in 4.3 master (1aab6e9)

System information

Windows 10

Issue description

When using the mobile renderer without any effects such as glow or dof or usage of screen texture, log is getting spammed with:

Tracker can't have more than one type of usage in the same draw list. Draw list usage is 15 and the requested usage is 14.
Tracker can't have more than one type of usage in the same draw list. Draw list usage is 15 and the requested usage is 14.
Tracker can't have more than one type of usage in the same draw list. Draw list usage is 15 and the requested usage is 14.

Steps to reproduce

  • Create a new project selecting the mobile renderer
  • Using the 3 dots environment settings button, turn OFF glow (on by default):
    image

Watch the errors fly by :)

Minimal reproduction project (MRP)

n/a

@BastiaanOlij
Copy link
Contributor Author

cc @DarioSamo

@BastiaanOlij
Copy link
Contributor Author

Note that this is caused by Godot applying a 2 subpass approach when no effects are on for maximum performance.
Subpass 1: Renders 3D content to an RGB10A2 buffer
Subpass 2: Reads from the RGB10A2 buffer, tonemaps and color corrects the result, and writes to our RGBA8 output.
This approach results in the RGB10A2 data never leaving tile memory.

Because subpass 1 writes to the RGB10A2 buffer, and subpass 2 reads from this buffer, the error is falsely given.

@DarioSamo
Copy link
Contributor

Important clarification: it only gets logged in dev builds as that's the one that detects the error, it won't happen in release builds. It doesn't actually result in an error because the underlying layout is the same Vulkan, but it's an error nevertheless.

I'll look into some possible solutions soon as it requires adding an exception to the graph for the particular case of the color attachment usage in both write and read only modes.

@BastiaanOlij
Copy link
Contributor Author

Important clarification: it only gets logged in dev builds as that's the one that detects the error, it won't happen in release builds. It doesn't actually result in an error because the underlying layout is the same Vulkan, but it's an error nevertheless.

You'd be amazed at how many users panic when they see errors, esp if it repeats :)

@DarioSamo
Copy link
Contributor

You'd be amazed at how many users panic when they see errors, esp if it repeats :)

Yeah it should get fixed, just clarifying in case someone wants to reproduce it you can only see it in dev build mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants