Node icon misplaced in Create New Scene dialog

[KoBeWi]

Tested versions

4.3 dev3
Does not happen in 4.2.1 (although there was different bug there)

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

Probably regression from some button icon PRs?

Previously it was aligned, but selection was broken:

It evolved I guess.

Steps to reproduce

1. Right click FileSystem dock
2. Create New
3. Scene...

Minimal reproduction project (MRP)

N/A

[AegisTTN]

If I did the bisects correctly, sorry for any mistake new to this, it seems that f29a7d3 first changed it to:

And then 567e76f changed it to what it currently is

[KoBeWi]

CC @Rindbee

[Rindbee]

This is a question of whether h_separation needs to be added between icons when calculating the minimum size. Currently h_separation needs to be added only when the text is not empty.

godot/scene/gui/check_box.cpp

Lines 69 to 71 in 652438a

	if (get_text().length() > 0) {
	minsize.width += MAX(0, theme_cache.h_separation);
	}

godot/scene/gui/check_button.cpp

Lines 73 to 75 in 652438a

	if (get_text().length() > 0) {
	minsize.width += MAX(0, theme_cache.h_separation);
	}