Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsurface Scattering Transmittance visual glitches #88083

Closed
ghost opened this issue Feb 8, 2024 · 4 comments · Fixed by #93448
Closed

Subsurface Scattering Transmittance visual glitches #88083

ghost opened this issue Feb 8, 2024 · 4 comments · Fixed by #93448

Comments

@ghost
Copy link

ghost commented Feb 8, 2024

Tested versions

  • Reproducible in: v4.2.1.stable.official [b09f793], v4.1.3.stable.official [f06b6836a], v4.0.3.stable.official [5222a99] - Not Reproducible in v3.5.1

System information

Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Laptop GPU (NVIDIA; 31.0.15.4633) - 11th Gen Intel(R) Core(TM) i5-11300H @ 3.10GHz (8 Threads)

Issue description

Subsurface scattering transmittance not working well with OmniLights (glitch border dependant on OmniLight's rotation for unknown reason, transmittance only functional from one side of the OmniLight dependant on how the omni light is rotated)

Secondary issue:
Visual glitching of transmittance on materials exclusively in the editor (glitch not present in-game)

Steps to reproduce

Add a MeshInstance3D to an empty 3D scene
assign any type of Mesh to it
give it a material
enable Subsurface Scattering in that material
enable Transmittance under Subsurface Scattering
increase Depth under Transmittance from 0.1 to 3.0

Add an OmniLight to the scene
make sure it's not inside the MeshInstance3D
enable shadows in that OmniLight

You should be able to notice a sort of "border" on the MeshInstance3D caused by transmittance, rotating the OmniLight will affect how transmittance behaves, which is not a desired behavior at all.

preview of the issue:
subsurd omni rotation dependant

preview of the secondary issue:
issue 2

Minimal reproduction project (MRP)

Subsurface scattering test.zip

@Calinou
Copy link
Member

Calinou commented Feb 8, 2024

Visual glitching of transmittance on materials exclusively in the editor (glitch not present in-game)

This may be a variant of #73697. Can you enable View Information in the 3D viewport's Perspective menu and check the resolution in the bottom-right corner?

@ghost
Copy link
Author

ghost commented Feb 8, 2024

This may be a variant of #73697. Can you enable View Information in the 3D viewport's Perspective menu and check the resolution in the bottom-right corner?

image

It seems that's likely the same issue, as if subsurface scattering simply had a tendency to break after a while of being enabled and messed around with.

@Calinou
Copy link
Member

Calinou commented Feb 8, 2024

It seems that's likely the same issue, as if subsurface scattering simply had a tendency to break after a while of being enabled and messed around with.

Your viewport resolution is even on both axes, so it's probably not the same issue 🙂

Does it appear on and off when the viewport is slowly resized (e.g. when you resize the editor window or drag a splitter next to it)?

@ghost
Copy link
Author

ghost commented Feb 8, 2024

Your viewport resolution is even on both axes, so it's probably not the same issue 🙂

Does it appear on and off when the viewport is slowly resized (e.g. when you resize the editor window or drag a splitter next to it)?

Nope, it stays the same all the time, even when I close the editor and re-open. Tho the initial time I had the issue it disappeared when I reloaded the project, but now it doesn't seem to go away.

@github-project-automation github-project-automation bot moved this to For team assessment in Rendering Issue Triage Jun 21, 2024
@clayjohn clayjohn moved this from For team assessment to Up for grabs in Rendering Issue Triage Jun 21, 2024
@clayjohn clayjohn moved this from Up for grabs to In progress / Assigned in Rendering Issue Triage Jun 22, 2024
@clayjohn clayjohn moved this from In progress / Assigned to Fix pending review in Rendering Issue Triage Jun 22, 2024
@clayjohn clayjohn added this to the 4.4 milestone Jun 22, 2024
@github-project-automation github-project-automation bot moved this from Fix pending review to Done in Rendering Issue Triage Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants