Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStreamPlayer3D autoplay does not work after AudioStreamPlayerInternal refactor #87730

Closed
aaronfranke opened this issue Jan 30, 2024 · 0 comments · Fixed by #87732
Closed

Comments

@aaronfranke
Copy link
Member

aaronfranke commented Jan 30, 2024

Tested versions

4.3-dev master as of today 51991e2 (happens on any commit after #87061)

System information

macOS 14.2.1, Apple M1 Pro

Issue description

AudioStreamPlayer3D's autoplay property does not work as of #87061

The ENTER_TREE notification is never run for the 3D node:

void AudioStreamPlayerInternal::notification(int p_what) {
	switch (p_what) {
		case Node::NOTIFICATION_ENTER_TREE: {
			print_line("enter tree");

The audio plays correctly if I use the remote scene tree to set playing to true.

Commits before #87061 work fine, and if I revert #87061 it works fine.

Steps to reproduce

  1. Open the minimal reproduction project.
  2. Set different audio player nodes as autoplay.
  3. Observe the following:
    • In master after 87061, AudioStreamPlayer3D autoplay does not work, but it works for 0D and 2D.
    • Before 87061, autoplay works on all players: 0D, 2D, and 3D.

Minimal reproduction project (MRP)

AudioStreamPlayerAutoPlayBroken.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants