-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't open project after deleting .godot folder #87593
Comments
What if you open it in a new self-contained instance of the editor? Sounds like another deadlock though. PS. If it's a deadlock, you can manually pause the debugger pretty much at any point and it's likely to stop around the code that is locked. |
Seems like it worked in a self-contained mode 🤔 |
inb4 it's EditorResourcePreview deadlocking while trying to generate a preview for GDScripts with unresolved class names or circular deps.. I think we should get rid of GDScript previews, or at least of the highlighting part that requires loading/parsing. |
I used debugger to see what is it doing in the background and seems like it's loading random scenes across the project. EDIT: |
Apparently the culprit is 958699a godot/editor/editor_file_system.cpp Lines 1687 to 1688 in da945ce
the project opens normally. It's only a problem if group cache does not exist. CC @DarkMessiah |
I found more info and I was right that it's related to TileSet.
First, the reason why it hangs itself in the first place: when you load a TileSet, it does a I assume what happens next is that godot/core/object/message_queue.cpp Lines 464 to 469 in da945ce
And print_line() is deferred :D Which means that it will try to use already full queue and recursively call the same function until everything dies.
There are 2 separate solutions to apply here:
Also since group scanning is so long, it should use EditorProgress and possibly happen over a few frames, to avoid clogging message queue. EDIT: |
This was done elsewhere, so makes sense here too, will open a PR for that |
#89493 prevents TileSet from exploding memory usage and #89490 prevents crashing if it still happens for some reason, so this issue is resolved (the project can be opened). Remaining problems mentioned here:
|
Tested versions
4.3 dev2
4.3 5034478
Works correctly in 4.2.1
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
I had some script errors due to deleted scripts, so I deleted script cache, but my project could no longer run. So I decided to delete the whole .godot folder and I can't open the project anymore. The RAM usage skyrockets to over 8GB and then either editor dies or the system freezes and then editor dies.
There is nothing useful in the output, even in verbose mode.
Steps to reproduce
Minimal reproduction project (MRP)
I can share the project privately.
It does not happen in a minimal one and I don't know which part causes the problem.
The text was updated successfully, but these errors were encountered: