Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile picking is broken #86400

Closed
KoBeWi opened this issue Dec 21, 2023 · 1 comment · Fixed by #86522
Closed

Tile picking is broken #86400

KoBeWi opened this issue Dec 21, 2023 · 1 comment · Fixed by #86522
Labels
bug regression topic:editor topic:rendering topic:2d
Milestone
4.3

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Dec 21, 2023

Tested versions

Reproducible in 4.3 dev1
Not reproducible in 4.2.1

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

godot.windows.editor.dev.x86_64_E9g3MqF8A4.mp4

Picking with draw tools (using Ctrl) doesn't display any preview.
Using selection tools shows weird grid.

4.2.1 for comparison:

godot_QkOemkRKTn.mp4

Steps to reproduce

  1. Add TileMap with TileSet
  2. Draw some tiles
  3. Try selecting them

Minimal reproduction project (MRP)

N/A
@KoBeWi KoBeWi added this to the 4.3 milestone Dec 21, 2023
@YuriSizov
Copy link
Contributor

Reverting to c28a091 fixes the issue, so this must be a regression from #83452. cc @RandomShaper

@RandomShaper RandomShaper mentioned this issue Dec 26, 2023
Merged
@KoBeWi KoBeWi mentioned this issue Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:editor topic:rendering topic:2d
Projects
4.x Release Blockers
Archived in project
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

RenderingDevice: Fix uniform sets wrongly assumed to be bound RandomShaper/godot
2 participants
@KoBeWi @YuriSizov