NavigationAgent3D: target_desired_distance works relatively on path_desired_distance

[evilenzo]

Tested versions

Reproducible in 4.2

System information

Godot v4.2.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 31.0.15.4617) - AMD Ryzen 7 7800X3D 8-Core Processor (16 Threads)

Issue description

In 3d navigation target desired distance is ignored when path desired distance is greater than it. I don't think these two variables should be in such dependency

Steps to reproduce

See the MRP. We have agent with path desired distance set to 5m and target desired distance set to 1m. But it stops on 5m before the last point (just click left mouse to start moving character to point). Use path debug visuals. You can also try to change path desired distance and see that it affects distance to target on navigation finish

Minimal reproduction project (MRP)

MRP Distance.zip

[evilenzo]

Short version: target desired distance less than path desired distance just doesn't work. It is being ignored. And I don't think anyone expects such behaviour

[evilenzo]

@Calinou no need in testing, I just checked Godot sources.

As we can see you check target_desired_distance here

godot/scene/3d/navigation_agent_3d.cpp

Line 826 in b94eb58

_check_distance_to_target();

But it is in loop that works with condition that checks path desired distance

godot/scene/3d/navigation_agent_3d.cpp

Line 768 in b94eb58

while (origin.distance_to(navigation_path[navigation_path_index] - Vector3(0, path_height_offset, 0)) < path_desired_distance) {

[evilenzo]

More than that

godot/scene/3d/navigation_agent_3d.cpp

Line 854 in b94eb58

emit_signal(SNAME("target_reached"));

This event is never emitted. You will get navigation_finished event, but not target_reached event in that case

[smix8]

PR #82561

[evilenzo]

Duplicate