-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationServer API is missing some getter functions #84495
Comments
Hello, I'd like to work on this! |
I've looked around the public class API for They seem to be generally the same set of methods, except Do let me know if there are any here that shouldn't have a getter
|
Everything else looks fine to receive a getter. |
Godot version
5ee9831
System information
Windows 10
Issue description
The NavigationServer API has many setter functions for navigation object properties but is often missing the getter function for the property.
For the majority of properties there is no real reason why they should have no getters, they were just never added.
E.g. the setter
agent_set_avoidance_layers()
has noagent_get_avoidance_layers()
getter function.Without getters some script uses are made more annoying and difficult as users need to track the properties externally somewhere and keep them updated with the server.
Steps to reproduce
TODO List:
NavigationServer2D
andNavigationServer3D
API.servers/navigation_server_2d.h
andservers/navigation_server_3d.h
.servers/navigation_server_2d.cpp
andservers/navigation_server_3d.cpp
_bind_methods()
function.modules/navigation/godot_navigation_server_2d.h
andmodules/navigation/godot_navigation_server.h
overrides
.modules/navigation/godot_navigation_server_2d.cpp
andmodules/navigation/godot_navigation_server.cpp
Note since the NavigationServer2D will have to call the NavigationServer3D some values need to be converted back and forth between 2D and 3D. Do not write manual conversions, use the existing static functions available in that file.
For the NavigationServer2D it is ok to NOT use the FORWARD_XYZ macros and instead write normal functions that call the NavigationServer3D. We want to get rid of those NavigationServer2D macro uses long-term anyway.
doc/classes/NavigationServer2D.xml
anddoc/classes/NavigationServer3D.xml
Minimal reproduction project
N/A
The text was updated successfully, but these errors were encountered: