Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Split Mode button icon missing #84309

Closed
robbertzzz opened this issue Nov 1, 2023 · 8 comments
Closed

Change Split Mode button icon missing #84309

robbertzzz opened this issue Nov 1, 2023 · 8 comments

Comments

@robbertzzz
Copy link

Godot version

v4.2.beta4.official [93cdacb]

System information

Windows 11

Issue description

The Change Split Mode button on the FileSystem tab is a white square, see image:

image

Steps to reproduce

Open the editor and look at the button

Minimal reproduction project

N/A

@timothyqiu
Copy link
Member

It's not missing, it's showing an unsplit layout. Clicking on it cycles through unsplit / hsplit / vsplit.

But yeah, it's confusing to see a white square 🤣

@YuriSizov
Copy link
Contributor

A new icon design is welcome! cc @MewPurPur

@MewPurPur
Copy link
Contributor

I wanted to tweak this one but I had no idea what to do with it.

@Calinou
Copy link
Member

Calinou commented Nov 1, 2023

What about something like VS Code's split editor/terminal icon?

image

It can be either vertical or horizontal.

@MewPurPur
Copy link
Contributor

MewPurPur commented Nov 1, 2023

That can't be it, it clashes with alternative icons. Here's the full family of them:

image

@robbertzzz
Copy link
Author

Those icons use negative space, can't you do the opposite?

image

@MewPurPur
Copy link
Contributor

I like how this looks, I'll do that.

@MewPurPur
Copy link
Contributor

Solved by #95344

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants