Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing an asset, you can't deselect a partially selected folder. #84021

Closed
Protowalker opened this issue Oct 26, 2023 · 1 comment · Fixed by #84953
Closed

When importing an asset, you can't deselect a partially selected folder. #84021

Protowalker opened this issue Oct 26, 2023 · 1 comment · Fixed by #84953

Comments

@Protowalker
Copy link

Godot version

4.1.2

System information

Godot v4.1.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; 31.0.15.3141) - 11th Gen Intel(R) Core(TM) i7-11375H @ 3.30GHz (8 Threads)

Issue description

When importing an asset, a file selection window line this appears:
image
You can select individual files or whole folders, and when a folder has some of its items selected but not all, it appears like this:
image
Clicking on this checkbox will select all of the items in the folder, then clicking it again will deselect all of the items in the folder. This is working as intended. However, if some of the files can't be imported, due to file type, conflict, being gdignored, whatever, clicking this button does nothing. It feels like a good idea to me that instead it should deselect all files, if the only files not selected can't be selected.
image

Steps to reproduce

  1. Open a project
  2. Go to AssetLib and hit import
  3. Select a zip file
  4. Find a folder with some unselectable files
  5. Try to deselect the parent folder

Minimal reproduction project

Open an empty godot project and attempt to import this zip:
SignalUtilities.zip
then try to deselect the .godot folder or the editor folder inside of .godot.

@YuriSizov
Copy link
Contributor

I think this was already reported somewhere because that's just how the intermediate mode works in Trees. It is annoying though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants