Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Timeline Go to Next Step / Prev Step is triggering the wrong player->seek #83394

Closed
VansonLeung opened this issue Oct 15, 2023 · 0 comments · Fixed by #85193
Closed

Comments

@VansonLeung
Copy link

VansonLeung commented Oct 15, 2023

Godot version

4.2.beta.custom_build [51f81e1]

System information

macOS 11.0+

Issue description

I could sense a recent merging of a few pull requests on here:

image

This bug has the following related merges as the most recent ones:

#80813
#80939

The pull requests are for reviving onion-skinning capabilities, but this causes a minor unexpected result (see Steps to reproduce)

Steps to reproduce

A. Use 4.2.beta.custom_build [51f81e1]

  1. Obtain the attached minimal reproduction project
  2. Select the AnimationPlayer node
image 3. In the Animation panel, click "Edit" to find your shortcuts for "Go to Next Step" and "Go to Previous Step" image 4. Use the shortcuts to spam go back and forth the animation

Expected result: animation goes smoothly

issue_2_expected_result.mp4

Actual result: animation jumps crazily

issue_3_crazy_movement.mp4
issue_4_backforth.mp4

B. My successful yet unverified fix attempt on 4.2.beta.custom_build [51f81e1]

Either by:

image

Or by:

image

I don't see any negative impact on Onion Skinning or other functions by the above fix attempt, but I am not sure, I need someone to help me verify this.

Minimal reproduction project

gd_anim_unittest_1.zip

@VansonLeung VansonLeung changed the title [Godot 4.2 Beta-1] Animation Timeline Go to Next Step / Prev Step is triggering the wrong player->seek [4.2.beta.custom_build] [51f81e1] Animation Timeline Go to Next Step / Prev Step is triggering the wrong player->seek Oct 15, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 16, 2023
@SaracenOne SaracenOne self-assigned this Oct 30, 2023
@akien-mga akien-mga changed the title [4.2.beta.custom_build] [51f81e1] Animation Timeline Go to Next Step / Prev Step is triggering the wrong player->seek Animation Timeline Go to Next Step / Prev Step is triggering the wrong player->seek Nov 14, 2023
@akien-mga akien-mga modified the milestones: 4.2, 4.3 Nov 14, 2023
@TokageItLab TokageItLab modified the milestones: 4.3, 4.2 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment