Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Plugin fails to load using suggested default plugin script folder #81431

Closed
duarteroso opened this issue Sep 7, 2023 · 6 comments
Closed

Comments

@duarteroso
Copy link

Godot version

4.2-dev4.mono

System information

macOS

Issue description

In the new Android plugin V2 documentation (draft), it is suggested to place the editor script files in a folder called .export.
Doing so will make it impossible to load the said plugin.

Steps to reproduce

  1. Create a C# plugin
  2. Place the plugin script in a folder called .export (or any .folder I think)
  3. Update the plugin.cfg with the new path
  4. Go to project settings
  5. Load the plugin

image

Minimal reproduction project

CSPlugin.zip

@duarteroso
Copy link
Author

Tagging @m4gr3d :)

@m4gr3d
Copy link
Contributor

m4gr3d commented Sep 7, 2023

@duarteroso Does the issue go away when removing the . from the path (e.g: res://addons/two/export/Two.cs)?

Also note that some of the changes were landed after dev4, so will be available starting with dev5. Though it shouldn't affect what you're currently testing.

@duarteroso
Copy link
Author

duarteroso commented Sep 8, 2023

@duarteroso Does the issue go away when removing the . from the path (e.g: res://addons/two/export/Two.cs)?

Also note that some of the changes were landed after dev4, so will be available starting with dev5. Though it shouldn't affect what you're currently testing.

It does yes (it is not in the MRP but I tried locally right after). My best guess is that dot-folders are skipped during parsing

If this is fixed in dev5, feel free to close this issue 👍🏽

@m4gr3d
Copy link
Contributor

m4gr3d commented Oct 9, 2023

It does yes (it is not in the MRP but I tried locally right after). My best guess is that dot-folders are skipped during parsing

If this is fixed in dev5, feel free to close this issue 👍🏽

@duarteroso I've updated the recommended plugin directory structure in godotengine/godot-docs#7884 to the following:

    MyPlugin/
    |
    +--MyPlugin.1.1.2.release.aar  # the release version of the aar file (naming standards is up to the creator)
    |
    +--MyPlugin.1.1.2.debug.aar  # the debug version of the aar file (naming standards is up to the creator)
    |
    +--export_plugin.gd         # export plugin tool script
    |
    +--plugin.cfg               # plugin INI file

Can you try the new approach and let me know if that resolves the issues you were seeing before.

@duarteroso
Copy link
Author

I've settled for this layout, similar to your original one (with the .folder for the platform AARs) 👍
Seems to be working fine so far.

image

@m4gr3d
Copy link
Contributor

m4gr3d commented Oct 9, 2023

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants